[webkit-reviews] review granted: [Bug 75531] The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces : [Attachment 121087] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 75531: The cpp parser of prepare-ChangeLog cannot detect a change in
classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531

Attachment 121087: Patch
https://bugs.webkit.org/attachment.cgi?id=121087&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121087&action=review


r=me, but please look into the duplicate namespace entry issue.

>
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-exp
ected.txt:311
> +  [
> +    '299',
> +    '300',
> +    'NameSpace6'
> +  ],
> +  [
> +    '302',
> +    '303',
> +    'NameSpace5'
>    ]

These NameSpace* entries seem to be duplicate/bogus (as are some other new
NameSpace* entries.  This doesn't seem to affect the output in the ChangeLog
entry (since the duplicate entries are apparently removed), but it seems like
something that should be cleaned up if it's easy to do.