[webkit-reviews] review granted: [Bug 73208] prepare-ChangeLog can recognize a here-document in Perl : [Attachment 121097] rebased patch for review

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73208: prepare-ChangeLog can recognize a here-document in Perl
https://bugs.webkit.org/show_bug.cgi?id=73208

Attachment 121097: rebased patch for review
https://bugs.webkit.org/attachment.cgi?id=121097&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121097&action=review


r=me if you fix the function regex.  Thanks for all the work getting to this
point!

> Tools/Scripts/prepare-ChangeLog:1294
> +	       if (/^sub\s+([\w\d]+)/) {

Technically a subroutine in Perl can't start with a number but can contain
underscores, so this should be something like this (untested):

	    if (/^sub\s+([\w_][\w\d_]*)/) {