[webkit-reviews] review granted: [Bug 65076] WebKit2: Printing to PDF loses URL links : [Attachment 121534] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 65076: WebKit2: Printing to PDF loses URL links
https://bugs.webkit.org/show_bug.cgi?id=65076

Attachment 121534: Patch v1
https://bugs.webkit.org/attachment.cgi?id=121534&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121534&action=review


r=me assuming you tested multi-page PDFs.

> Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:509
> +    RetainPtr<NSData> pdfData(AdoptNS, [[NSData alloc]
initWithBytes:pdfDataBytes.data() length:pdfDataBytes.size()]);

It's a little sad that we now copy the data.

> Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:533
> +	   RetainPtr<NSData> pdfData(AdoptNS, [[NSData alloc]
initWithBytes:_printedPagesData.data() length:_printedPagesData.size()]);

Ditto.