[webkit-reviews] review denied: [Bug 75746] [Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload : [Attachment 121505] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 75746: [Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload
https://bugs.webkit.org/show_bug.cgi?id=75746

Attachment 121505: Patch
https://bugs.webkit.org/attachment.cgi?id=121505&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121505&action=review


> Source/WebKit2/ChangeLog:8
> +	   Revert r103760 because it causes leak of GraphicsLayerTextureMapper 

> +	   objects on UI side and reset WebGraphicsLayer::m_layerTreeTileClient

> +	   of all dependent layers from ~LayerTreeHostQt().

This is more than a revert :)
Changelog should explain that it fixes the original bug from 103760 in a way
that doesn't create leaks.

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:621
> +    if (m_layerTreeTileClient != client) {
> +	   for (size_t i = 0; i < children().size(); ++i) {

Early return