[webkit-reviews] review requested: [Bug 74352] [skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater : [Attachment 121510] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 74352: [skia] Track a simple opaque area when painting via
PlatformContextSkia and save in LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=74352

Attachment 121510: Patch
https://bugs.webkit.org/attachment.cgi?id=121510&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Comments addressed.

Reworked the tracking a bit so the opaque-ness is considered for
paths/points/lines/etc also. if they are only drawing opaque pixels then they
shouldn't damage our current opaqueRect.

Buffed up the tests some. Added some actual pixel tests too to check for false
positives. (Disabled pending skia-side fixes. [1])

There are two things that I wasn't totally sure about - I'll point them out via
the review system.

[1] http://codereview.appspot.com/5494076/