[webkit-reviews] review granted: [Bug 75662] Pixel results from DumpRenderTree and WebKitTestRunner don't match, suffer colorspace issues : [Attachment 121354] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 75662: Pixel results from DumpRenderTree and WebKitTestRunner don't match,
suffer colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=75662

Attachment 121354: Patch
https://bugs.webkit.org/attachment.cgi?id=121354&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=121354&action=review


> Tools/ChangeLog:3
> +	   Pixel results from DumpRenderTree and WebKitTestRunner don't match,
suffer colorspace issues

I think it’s us who suffer. The pixel results are secretly enjoying it.

> Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:55
> +    // Creating this bitmap in the device color space should prevent any
color conversion when the image of the web view is drawn into it.

Can you say “prevents” instead of “should prevent”? Does it not really do what
it should do?