[webkit-reviews] review denied: [Bug 75730] Repaint all graphics layers when their renderer offset changes : [Attachment 121478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 6 13:43:46 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adrienne Walker
<enne at google.com>'s request for review:
Bug 75730: Repaint all graphics layers when their renderer offset changes
https://bugs.webkit.org/show_bug.cgi?id=75730

Attachment 121478: Patch
https://bugs.webkit.org/attachment.cgi?id=121478&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think I'd prefer that the responsibility for calling setNeedsDisplay remains
with the GraphicsLayer client, and is not pushed down to GraphicsLayer. My
justification is that GraphicsLayer doesn't actually use m_offsetFromRenderer
in its painting code at all (but perhaps it should?)


More information about the webkit-reviews mailing list