[webkit-reviews] review granted: [Bug 67217] Mitigate scrollbar differences when running pixel tests : [Attachment 121471] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 67217: Mitigate scrollbar differences when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=67217

Attachment 121471: Patch
https://bugs.webkit.org/attachment.cgi?id=121471&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=121471&action=review


> Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm:46
> + at interface NSScrollView(AppKitSecretsIKnowAbout)

The modern convention for such category names is “WebNSScrollViewDetails”.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:458
> +	   CGFloat knobPosition = round([self doubleValue] * (trackLength -
knobLength));

Will round() here work in 32-bit?

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:463
> +	   return NSMakeRect(bounds.origin.x, bounds.origin.y +  +
knobPosition, bounds.size.width, knobLength);

+ +

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:474
> +    NSColor *knobColor = [NSColor colorWithDeviceRed:0x80 / 255.0 green:0x80
/ 255.0 blue:0x80 / 255.0 alpha:1];

Could make this a function static (and retain the color).

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:482
> +    NSColor *trackColor = [NSColor colorWithDeviceRed:0xC0 / 255.0
green:0xC0 / 255.0 blue:0xC0 / 255.0 alpha:1];

Ditto.