[webkit-reviews] review granted: [Bug 72555] Make TextTrackCue more mutable : [Attachment 121321] Updated patch - hopefully pedantic AND correct this time.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 72555: Make TextTrackCue more mutable
https://bugs.webkit.org/show_bug.cgi?id=72555

Attachment 121321: Updated patch - hopefully pedantic AND correct this time.
https://bugs.webkit.org/attachment.cgi?id=121321&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121321&action=review


> Source/WebCore/html/TextTrackCue.cpp:197
> +    if (direction != m_writingDirection) {

I'd make this an early return instead.

> Source/WebCore/html/TextTrackCue.cpp:304
> +    if (alignment != m_cueAlignment) {

Early return.

> Source/WebCore/html/TextTrackCue.h:63
> +    void setId(String);

This should take a const String&