[webkit-reviews] review denied: [Bug 75705] [Chromium] Disable per-tile painting support on Windows. : [Attachment 121436] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 75705: [Chromium] Disable per-tile painting support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75705

Attachment 121436: Patch
https://bugs.webkit.org/attachment.cgi?id=121436&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121436&action=review


> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:127
> +#if defined(WIN32)

in WebKit we use OS(WINDOWS)

> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:128
> +    ASSERT(!host->settings().perTilePainting);

not sure this is useful to have. if we don't want to support the flag, then we
should just ignore it

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:99
> +#if defined(WIN32)
> +    ASSERT(!m_settings.perTilePainting); // No per-tile painting support on
Windows.
> +#endif

how is this helpful? it won't help us with crashes in the field, since
ASSERT()s are only active in debug builds