[webkit-reviews] review requested: [Bug 75126] Add normalize attribute to ConvolverNode to disable normalization. : [Attachment 121348] Patch

[bugzilla-daemon at webkit.org]

Raymond Toy <rtoy at chromium.org> has asked  for review:
Bug 75126: Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126

Attachment 121348: Patch
https://bugs.webkit.org/attachment.cgi?id=121348&action=review

------- Additional Comments from Raymond Toy <rtoy at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121348&action=review


>> LayoutTests/webaudio/resources/convolution-testing.js:93
>> +	    testFailed("Triangular portion of convolution is not incorrect. 
Max deviation = " + maxDeviationFraction + " at " + maxDeltaIndex);
> 
> "is not incorrect" -> "is not correct"

Fixed.

Also, I've changed the thresholds so that the tests will pass on OSX.  The
thresholds and such are now in "dB" units, relative to the max of the
triangular pulse.