[webkit-reviews] review granted: [Bug 75712] NRWT mysteriously exits when Apache returns an error code : [Attachment 121444] Print an error message when NRWT can't run Apache

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 75712: NRWT mysteriously exits when Apache returns an error code
https://bugs.webkit.org/show_bug.cgi?id=75712

Attachment 121444: Print an error message when NRWT can't run Apache
https://bugs.webkit.org/attachment.cgi?id=121444&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121444&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:240
> +		   _log.error("httpd returned an error code. Cannot run http
tests.")

Nit: can you rephrase this to give a little context to what we were doing?
something like "checking if httpd works failed (httpd returned an error code).
Cannot run http tests".