[webkit-reviews] review granted: [Bug 75693] Move FrameDestructionObserver to its own file : [Attachment 121416] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 75693: Move FrameDestructionObserver to its own file
https://bugs.webkit.org/show_bug.cgi?id=75693

Attachment 121416: Patch
https://bugs.webkit.org/attachment.cgi?id=121416&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121416&action=review


LGTM.

> Source/WebCore/page/FrameDestructionObserver.h:42
> +    Frame* m_frame;

Having the storage on FrameDestructionObserver is probably slightly
controvertial.	Theoretically one might want a FrameDestructionObserver that
had its own Frame storage, but the common case probably wants this concrete
instance.  We may eventually want to separate out the ABC from this common
concrete instance.