[webkit-reviews] review granted: [Bug 73957] Repaint video controls when buffering during pause. : [Attachment 121142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 17:30:26 PST 2012


MORITA Hajime <morrita at google.com> has granted Dale Curtis
<dalecurtis at chromium.org>'s request for review:
Bug 73957: Repaint video controls when buffering during pause.
https://bugs.webkit.org/show_bug.cgi?id=73957

Attachment 121142: Patch
https://bugs.webkit.org/attachment.cgi?id=121142&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121142&action=review


Looks good, with small nit.

> Source/WebCore/html/shadow/MediaControlRootElement.h:115
> +    void bufferingProgressed();

Nit: As WebKit being under influence of Obj-C, generally this would be named
didBufferingProgress().


More information about the webkit-reviews mailing list