[webkit-reviews] review granted: [Bug 70533] [Chromium] Cull occluded tiles in tiled layers : [Attachment 121336] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 70533: [Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533

Attachment 121336: Patch
https://bugs.webkit.org/attachment.cgi?id=121336&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121336&action=review


R=me. I'd like to see test coverage for a couple more cases, but otherwise
we're good to go.

> Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp:81
> +	   if (keepQuad && drawQuad->drawsOpaque() &&
drawQuad->isLayerAxisAlignedIntRect())

can you please add some tests for non-axis aligned quads to make sure that we
(a) don't consider them as generating opaque regions and (b) only cull when
it's definitely safe to do so?

> Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012