[webkit-reviews] review granted: [Bug 74203] [chromium] Create iterators for the RenderSurface-Layer tree : [Attachment 121367] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 17:15:46 PST 2012
James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 74203: [chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203
Attachment 121367: Patch
https://bugs.webkit.org/attachment.cgi?id=121367&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121367&action=review
Awesome, R=me!
> Source/WebCore/platform/graphics/chromium/cc/CCLayerIterator.cpp:150
> +// Declare each of the above functions for LayerChromium and CCLayerImpl
classes so that they are linked.
> +template void
CCLayerIteratorActions::BackToFront::begin(CCLayerIteratorPosition<LayerChromiu
m, RenderSurfaceChromium>&);
can you confirm that this compiles fine in visual studio before landing (it's
not too advanced, but i've had odd problems with template instantiation before
with msvs)? tryjobs should do the trick
> Source/WebKit/chromium/tests/CCLayerIteratorTest.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.
2012, please
More information about the webkit-reviews
mailing list