[webkit-reviews] review granted: [Bug 75200] REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally : [Attachment 121331] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 17:11:37 PST 2012


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 75200: REGRESSION (r90797): Full screen video HUD cannot be dragged
horizontally
https://bugs.webkit.org/show_bug.cgi?id=75200

Attachment 121331: Patch
https://bugs.webkit.org/attachment.cgi?id=121331&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121331&action=review


r=me, although I would rather you use mediaControlsElement() if possible.

> LayoutTests/fullscreen/video-controls-drag.html:19
> +		   panel = internals.shadowRoot(video).firstChild.firstChild;

Ick, why hard code the position of the element in the shadow DOM instead of
looking it up by name?


More information about the webkit-reviews mailing list