[webkit-reviews] review granted: [Bug 75593] null-check variable page before using it in FrameView::notifyPageThatContentAreaWillPaint. : [Attachment 121199] null-check variable 'page', to follow the usage pattern of m_frame->page() throughout the rest of FrameView.cpp.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 16:56:00 PST 2012
Alexey Proskuryakov <ap at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 75593: null-check variable page before using it in
FrameView::notifyPageThatContentAreaWillPaint.
https://bugs.webkit.org/show_bug.cgi?id=75593
Attachment 121199: null-check variable 'page', to follow the usage pattern of
m_frame->page() throughout the rest of FrameView.cpp.
https://bugs.webkit.org/attachment.cgi?id=121199&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I guess it's OK to add = another null check (there is enough confusion about
when they are needed in this file already).
It would be much better to find out why anyone would call
notifyPageThatContentAreaWillPaint() when there is no page, and they are not
painting, and fix that instead.
More information about the webkit-reviews
mailing list