[webkit-reviews] review granted: [Bug 73051] WebCore implementation of the Intent object. : [Attachment 121357] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 73051: WebCore implementation of the Intent object.
https://bugs.webkit.org/show_bug.cgi?id=73051

Attachment 121357: Patch
https://bugs.webkit.org/attachment.cgi?id=121357&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121357&action=review


> Source/WebCore/ChangeLog:5
> +	   WebCore implementation of the Intent object
> +	   See
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
> +	   for draft spec.

Ideally, we'd include some more information in the ChangeLog, but I think this
is ok for this patch.

> Source/WebCore/Modules/intents/Intent.cpp:76
> +void Intent::setData(SerializedScriptValue* data)

I would have just inlined this into the constructor.

> Source/WebCore/Modules/intents/Intent.h:55
> +    int identifier() const;
> +    void setIdentifier(int);

What is an identifier?	This doesn't seem to be needed as part of this patch. 
Can we add this later when needed?