[webkit-reviews] review granted: [Bug 73051] WebCore implementation of the Intent object. : [Attachment 121343] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 73051: WebCore implementation of the Intent object.
https://bugs.webkit.org/show_bug.cgi?id=73051

Attachment 121343: Patch
https://bugs.webkit.org/attachment.cgi?id=121343&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121343&action=review


> Source/WebCore/Modules/intents/Intent.idl:29
> +	 ConstructorParameters=3,

This isn't needed.

> Source/WebCore/Modules/intents/Intent.idl:35
> +	   readonly attribute [InitializedByConstructor] DOMString action;
> +	   readonly attribute [InitializedByConstructor] DOMString type;
> +	   readonly attribute [InitializedByConstructor] SerializedScriptValue
data;

[InitializedByConstructor] isn't needed.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1874
> -    return if ($attribute->signature->type eq "SerializedScriptValue");
> +#	return if ($attribute->signature->type eq "SerializedScriptValue");

This isn't needed.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2241
> -	       next;
> +	       # next;

Nor is this.

> Source/WebCore/page/DOMWindow.idl:612
> +	   attribute [Conditional=WEB_INTENTS] IntentConstructor Intent; //
Usable with the new operator

We should actually use the new supplemental machinery here (see
DOMWindowWebAudio.idl), but lets do that in a follow-up patch.