[webkit-reviews] review granted: [Bug 61326] fast/storage/storage-detached-iframe.html is crashing on chromium-linux : [Attachment 121334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 15:06:51 PST 2012


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 61326: fast/storage/storage-detached-iframe.html is crashing on
chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=61326

Attachment 121334: Patch
https://bugs.webkit.org/attachment.cgi?id=121334&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121334&action=review


> Source/WebKit/chromium/src/StorageAreaProxy.cpp:170
> +    // Disallow all access to storage on detached frames.

I would skip these comments.  They're redundant with the code.

> LayoutTests/fast/storage/storage-detached-iframe.html:24
> +	     } catch (e) {

Should we print a success message in this catch?


More information about the webkit-reviews mailing list