[webkit-reviews] review granted: [Bug 75641] [V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor] : [Attachment 121311] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 75641: [V8] CodeGeneration for SerializedScriptValue doesn't play nice with
[Constructor]
https://bugs.webkit.org/show_bug.cgi?id=75641

Attachment 121311: Patch
https://bugs.webkit.org/attachment.cgi?id=121311&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121311&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1648
> +    push(@implContent, "    v8::Handle<v8::Object> wrapper =
args.Holder();\n");

Oh I see this is needed for consistency with GenerateEagerDeserialization.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1662
> +	   GenerateEagerDeserialization($serializedAttribute);

This is the only real change.