[webkit-reviews] review granted: [Bug 75519] [GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations : [Attachment 121064] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 75519: [GTK] [AC] Introduce AcceleratedCompositingContext to isolate
different accelerated compositing implementations
https://bugs.webkit.org/show_bug.cgi?id=75519

Attachment 121064: Patch
https://bugs.webkit.org/attachment.cgi?id=121064&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121064&action=review


Great patch.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:34
> +class TextureMapper;
> +class TextureMapperNode;

Should this be avoided in case of clutter compilation?

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:87
> +    if (rect == IntRect())
> +	   m_rootGraphicsLayer->setNeedsDisplay();

Shouln't we return in this clause to avoid the next setNeedsDisplay with emtpy
rect? Are we testing if rect.isEmpty()?