[webkit-reviews] review granted: [Bug 75550] Pass WebFrame instead of WebCore::Frame to the WebKit2 specific FrameNetworkingContext : [Attachment 121254] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 04:04:11 PST 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alexander Færøy
<ahf at 0x90.dk>'s request for review:
Bug 75550: Pass WebFrame instead of WebCore::Frame to the WebKit2 specific
FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=75550
Attachment 121254: Patch
https://bugs.webkit.org/attachment.cgi?id=121254&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121254&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:37
> + // The page ID is needed later for HTTP authentication and SSL errors.
> + m_originatingObject->setProperty("pageID",
qulonglong(frame->page()->pageID()));
you do more in your patch than what you advertise
More information about the webkit-reviews
mailing list