[webkit-reviews] review canceled: [Bug 75532] [v8] Null pointer exception if a typed array constructor set to a primitive value. : [Attachment 121106] More robust guard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 02:34:53 PST 2012


Ulan Degenbaev <ulan at chromium.org> has canceled Ulan Degenbaev
<ulan at chromium.org>'s request for review:
Bug 75532: [v8] Null pointer exception if a typed array constructor set to a
primitive value.
https://bugs.webkit.org/show_bug.cgi?id=75532

Attachment 121106: More robust guard
https://bugs.webkit.org/attachment.cgi?id=121106&action=review

------- Additional Comments from Ulan Degenbaev <ulan at chromium.org>
Thank you for the suggestion, Ken. Those two lines even without guards would
indeed fix the issue.

Adam, I had a solution that avoided patching, but it was several factors slower
then the current solution because V8 couldn't inline it.


More information about the webkit-reviews mailing list