[webkit-reviews] review granted: [Bug 75290] [Refactoring] Migration over TreeScopes should be done by its own class. : [Attachment 121231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 01:48:53 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 75290: [Refactoring] Migration over TreeScopes should be done by its own
class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Attachment 121231: Patch
https://bugs.webkit.org/attachment.cgi?id=121231&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121231&action=review


> Source/WebCore/dom/TreeScopeAdopter.cpp:72
> +void TreeScopeAdopter::moveTreeToNewDocument(Node* root, Document*
oldDocument, Document* newDocument) const

No rename for this function?

> Source/WebCore/dom/TreeScopeAdopter.cpp:83
> +static bool didMoveToNewDocumentWasCalled;
> +static Document* oldDocumentDidMoveToNewDocumentWasCalledWith;

Please initialize these variables.


More information about the webkit-reviews mailing list