[webkit-reviews] review granted: [Bug 75605] WTF logging functions should call vprintf_stderr_common only once per line : [Attachment 121227] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 00:21:42 PST 2012


mitz at webkit.org has granted Mark Rowe (bdash) <mrowe at apple.com>'s request for
review:
Bug 75605: WTF logging functions should call vprintf_stderr_common only once
per line
https://bugs.webkit.org/show_bug.cgi?id=75605

Attachment 121227: Patch v1
https://bugs.webkit.org/attachment.cgi?id=121227&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=121227&action=review


> Source/JavaScriptCore/wtf/Assertions.cpp:134
> +    strcat(formatWithPrefix.get(), format);

This is effectively strlen()ing prefix again. You could have done this a little
more efficiently.


More information about the webkit-reviews mailing list