[webkit-reviews] review granted: [Bug 72017] [EFL] Replace alloca to C++ new placement : [Attachment 121226] updated patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Grzegorz
<g.czajkowski at samsung.com>'s request for review:
Bug 72017: [EFL] Replace alloca to C++ new placement
https://bugs.webkit.org/show_bug.cgi?id=72017

Attachment 121226: updated patch
https://bugs.webkit.org/attachment.cgi?id=121226&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121226&action=review


r=me

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:164
> -    Edje_Message_Float_Set* message = static_cast<Edje_Message_Float_Set*>
> -	   (alloca(sizeof(Edje_Message_Float_Set) + sizeof(float)));
> +    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
> +    Edje_Message_Float_Set* message =
reinterpret_cast<Edje_Message_Float_Set*>(buffer);

Please note in the ChangeLog why you are changing from float to double.