[webkit-reviews] review granted: [Bug 42723] FileReader needs addEventListener : [Attachment 121197] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 4 23:40:00 PST 2012
Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 42723: FileReader needs addEventListener
https://bugs.webkit.org/show_bug.cgi?id=42723
Attachment 121197: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=121197&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121197&action=review
> LayoutTests/fast/files/file-reader-event-listener.html:40
> + if (layoutTestController.notifyDone)
Do you mean:
if (window.layoutTestController)
layoutTestController.notifyDone();
?
> LayoutTests/fast/files/file-reader-event-listener.html:84
> + window.onload = runTests;
Should we alert a message if eventSender isn't present?
More information about the webkit-reviews
mailing list