[webkit-reviews] review granted: [Bug 75577] [chromium] Route all animate calls through CCLayerTreeHost in composited mode to simplify rate limiting logic : [Attachment 121193] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 75577: [chromium] Route all animate calls through CCLayerTreeHost in
composited mode to simplify rate limiting logic
https://bugs.webkit.org/show_bug.cgi?id=75577

Attachment 121193: Patch
https://bugs.webkit.org/attachment.cgi?id=121193&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121193&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:1136
> +#if USE(ACCELERATED_COMPOSITING)

nit: What about moving this code into WebViewImpl::updateAnimations, or if not,

then perhaps WebViewImpl::updateAnimations should be renamed to indicate that
it
should only be called when not in accelerated compositing mode?  Maybe add an
assertion too?

> Source/WebKit/chromium/src/WebViewImpl.h:112
> +    // This also implements WebCore::CCLayerTreeHostClient::layout()

micro-nit: maybe put this comment inline so the flow of function declarations
is not disrupted?

  virtual void layout(); // Also implements CCLayerTreeHostClient::layout()