[webkit-reviews] review requested: [Bug 75342] Adjust spill order in DFG : [Attachment 121216] patch updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 22:18:30 PST 2012


Yuqiang Xian <yuqiang.xian at intel.com> has asked  for review:
Bug 75342: Adjust spill order in DFG
https://bugs.webkit.org/show_bug.cgi?id=75342

Attachment 121216: patch updated
https://bugs.webkit.org/attachment.cgi?id=121216&action=review

------- Additional Comments from Yuqiang Xian <yuqiang.xian at intel.com>
Update the patch to _not_ adjust the spill order for 64bit, i.e. still Integers
have lower priority to be spilled as there may be additional operations - in
some cases the spilled integers are boxed as JS integers when being filled
(btw, is it necessary?). The regression of the last patch on
imaging-gaussian-blur should be caused by this.
So this patch keeps the spill order for 64bit as is, but simply modifies the
comments a bit to better describe the reason, and also removes
SpillOrderBoolean for 64bit as it's never used.


More information about the webkit-reviews mailing list