[webkit-reviews] review denied: [Bug 72078] [Chromium] Compositing with full sized fixed div causes heavy repaints : [Attachment 121036] patch v2 (fixed style issues)

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 72078: [Chromium] Compositing with full sized fixed div causes heavy
repaints
https://bugs.webkit.org/show_bug.cgi?id=72078

Attachment 121036: patch v2 (fixed style issues)
https://bugs.webkit.org/attachment.cgi?id=121036&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121036&action=review


I'm guessing the issue here is texture use that's higher than the reclaim limit
but lower than the absolute limit, right?  Looks like this without this patch
we're reducing to the reclaim limit on every frame, regardless of what's
visible.

This change seems reasonable to me, although it's effectively making the
reclaim limit much weaker. I think you definitely need tests for a subtle
behavior change like this.

> Source/WebKit/chromium/ChangeLog:12
> +	   No new tests as it doesn't change any functionality.

you definitely are changing functionality, so a test would be nice