[webkit-reviews] review granted: [Bug 75590] webkitpy: clean up port factory methods : [Attachment 121194] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 75590: webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Attachment 121194: Patch
https://bugs.webkit.org/attachment.cgi?id=121194&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121194&action=review


Seems sane.  Thanks!

> Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py:-108
> -	   # The actual Chrome class names aren't available so we test that the

> -	   # objects we get are at least subclasses of the Chromium versions.

This is some legacy from the days of the split repo?