[webkit-reviews] review denied: [Bug 75296] JSString should not have JS_EXPORTCLASS annotation : [Attachment 120640] Patch

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 75296: JSString should not have JS_EXPORTCLASS annotation
https://bugs.webkit.org/show_bug.cgi?id=75296

Attachment 120640: Patch
https://bugs.webkit.org/attachment.cgi?id=120640&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
It looks like Windows needs the class declaration exported in order to provide
access to JSString's vtable. I'd have to double-check, but I think the reason
this patch works for other platforms is that gcc lets you add the class's
vtable to the symbol exports file, but Windows does not. This is probably why
we have JS_EXPORTCLASS and JS_EXPORTDATA macros even though we're using symbol
export files.