[webkit-reviews] review granted: [Bug 74666] [chromium] FileSystem bridge needs threadsafe fixes and other clean-up. : [Attachment 121174] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 74666: [chromium] FileSystem bridge needs threadsafe fixes and other
clean-up.
https://bugs.webkit.org/show_bug.cgi?id=74666

Attachment 121174: Patch
https://bugs.webkit.org/attachment.cgi?id=121174&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121174&action=review


r+ with couple nits.

> LayoutTests/http/tests/workers/resources/sync-operations.js:22
> +	for (var i = 0; i < 10; ++i) {

Indenting.

> LayoutTests/http/tests/workers/resources/sync-operations.js:69
> +	return;

This needs comment on why it is needed and why it is ok to just return.

> LayoutTests/http/tests/workers/terminate-during-sync-operation.html:78
> +<div id='result'>

It'd be nice to add a sentence here describing what this test is testing and
what is expected PASS or FAIL results. So the people can figure the purpose of
the test w/o looking at the several related bugs.