[webkit-reviews] review granted: [Bug 71263] Report correct line number for non-native editable text elements. : [Attachment 121179] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 71263: Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263

Attachment 121179: Patch
https://bugs.webkit.org/attachment.cgi?id=121179&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121179&action=review


r=me provided nits are addressed.

> Source/WebCore/ChangeLog:9
> +	   set by the developer on an element which behaves like an editable
text element (such as a

s/developer/author/; also "set on an element" seems sufficient here.

> Source/WebCore/ChangeLog:15
> +	   visible_units, aware of the notion that an element may be
non-natively editable, via the
> +	   EditableType enum added to EditingBoundary.h.

the word "native" usually refers to platform-naiveness. Also, saying non-native
doesn't tell us what they're so it's probably better to say "an element maybe
editable via text-control ARIA role"