[webkit-reviews] review granted: [Bug 73853] Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+) : [Attachment 120828] Changed per Darin's comment

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 73853: Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged
(20%+)
https://bugs.webkit.org/show_bug.cgi?id=73853

Attachment 120828: Changed per Darin's comment
https://bugs.webkit.org/attachment.cgi?id=120828&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=120828&action=review


> Source/WebCore/dom/DynamicNodeList.h:109
> +	   void setLengthCache(Node* node, unsigned length)
> +	   {
> +	       if (m_isItemCacheValid && !domVersionIsConsistent()) {
> +		   m_cachedItem = node;
> +		   m_isItemCacheValid = false;
> +	       }
> +	       m_cachedLength = length;
> +	       m_isLengthCacheValid = true;
> +	   }

You should move the functions to cpp (with inline keyword) as that is the only
place they are used.

> Source/WebCore/dom/DynamicNodeList.h:132
> +	   unsigned m_cachedLength;
> +	   bool m_isLengthCacheValid : 1;
> +	   bool m_isItemCacheValid : 1;

You could steal the space for these bits from some other field.