[webkit-reviews] review granted: [Bug 75550] [Qt] Pass WebKit::WebFrame instead of WebCore::Frame to WebFrameNetworkingContext : [Attachment 121114] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alexander Færøy
<ahf at 0x90.dk>'s request for review:
Bug 75550: [Qt] Pass WebKit::WebFrame instead of WebCore::Frame to
WebFrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=75550

Attachment 121114: Patch
https://bugs.webkit.org/attachment.cgi?id=121114&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121114&action=review


Please fix the changelog and bug title

> Source/WebKit2/ChangeLog:4
> +	   [Qt] Pass WebKit::WebFrame instead of WebCore::Frame to
WebFrameNetworkingContext
> +	   https://bugs.webkit.org/show_bug.cgi?id=75550

This is not Qt only, so please remove the Qt part.

Pass WebFrame instead of WebCore::Frame to the WebKit2 specific
FrameNetworkingContext

> Source/WebKit2/ChangeLog:9
> +	   This patch changes the constructor of the various, port-specific,
> +	   WebFrameNetworkingContext-classes to take a pointer to a
> +	   WebKit::WebFrame instead of a WebCore::Frame. This is needed for the

> +	   Qt port to implement HTTP authentication and SSL support.

You say it is port specific, so why do you need to change that for all ports...
could you make this more clear?

Make the WebKit2 FrameNetworkingContext implementation store the WebFrame
instead of the WebCore::Frame as this is needed for the Qt port to implement
a.o.
HTTP autentication and SSL Support.

As the WebFrameNetworkingContext is partly shared across all WebKit2 ports, all

port specific files have been modified.