[webkit-reviews] review granted: [Bug 75559] Move Gamepad declarations from Navigator.idl into Modules/gamepad : [Attachment 121121] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 4 11:43:12 PST 2012
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 75559: Move Gamepad declarations from Navigator.idl into Modules/gamepad
https://bugs.webkit.org/show_bug.cgi?id=75559
Attachment 121121: Patch
https://bugs.webkit.org/attachment.cgi?id=121121&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121121&action=review
> Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:45
> + // FIXME: We shouldn't need direct this call to Navigator.
I think you're missing a "to" here.
I assume this is just a baby-step and you plan to move the code out of
navigator.cpp in a second patch...
More information about the webkit-reviews
mailing list