[webkit-reviews] review denied: [Bug 75539] getComputedStyle for background is not implemented. : [Attachment 121102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 10:19:45 PST 2012


Tony Chang <tony at chromium.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 75539: getComputedStyle for background is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75539

Attachment 121102: Patch
https://bugs.webkit.org/attachment.cgi?id=121102&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121102&action=review


>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.htm
l:36
> +e.style.backgroundImage = "url(dummy://test.png)";

Where are the tests for setting backgroundRepeat, backgroundAttachment or
backgroundPosition?  Also, it would be nice to add an identify check like the
one mentioned in the border image patch.


More information about the webkit-reviews mailing list