[webkit-reviews] review granted: [Bug 75347] getComputedStyle for border-image is not implemented. : [Attachment 121099] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 75347: getComputedStyle for border-image is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75347

Attachment 121099: Patch
https://bugs.webkit.org/attachment.cgi?id=121099&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121099&action=review


> LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html:56
> +shouldBe("computedBorderImageStyle('url(dummy://test.png) 10 / 13px / 11px',
'border-image')", "'url(dummy://test.png) 10 / 13px / 11px stretch'");

Can you add some tests that setting border-image to the value returned by
getComputedStyle doesn't change the value.  That is, for each of the different
values:
var before = window.getComputedStyle(testDiv).getPropertyValue('border-image');

testDiv.style.borderImage = 'none';
testDiv.style.borderImage = before;
assert(window.getComputedStyle(testDiv).getPropertyValue('border-image') ==
before);

It would be nice to have this kind of check for all future getComputedStyle
changes.