[webkit-reviews] review granted: [Bug 75433] [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+ : [Attachment 121088] Updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 75433: [GTK] Rename webkit_web_view_load_alternate_html as
webkit_web_view_replace_content in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=75433

Attachment 121088: Updated patch
https://bugs.webkit.org/attachment.cgi?id=121088&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121088&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:782
> + * Replace the content of @web_view with @content using @content_uri as page
URI.
> + * This allows clients to display page-loading errors in the #WebKitWebView
itself.
> + * This is typically called from #WebKitWebView::load-failed signal. The URI
passed in
> + * @base_uri has to be an absolute URI.
> + * Signals #WebKitWebView::load-changed and #WebKitWebView::load-failed are
not emitted
> + * when replacing content of a #WebKitWebView using this method.

Oh, there is one more thing I forgot to mention here. The documentation should
also state that the content type will be HTML. This is one way this method
differs from load_content.