[webkit-reviews] review granted: [Bug 74993] [EFL] Refactor the way using cairo in ewk_tiled_backing_store. : [Attachment 120855] Patch rebased.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 00:38:26 PST 2012


Nikolas Zimmermann <zimmermann at kde.org> has granted KwangHyuk
<hyuki.kim at samsung.com>'s request for review:
Bug 74993: [EFL] Refactor the way using cairo in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=74993

Attachment 120855: Patch rebased.
https://bugs.webkit.org/attachment.cgi?id=120855&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Rubberstamping this. I had worries about the RefPtr<> now being obsolete (that
was already commented here, why its ok) as well as the needless recreation of
the surfaces, but I was told its no measurable difference, and eg. FF wouldn't
cache cairo_t/cairo_surface_t objects as well, so r=me.


More information about the webkit-reviews mailing list