[webkit-reviews] review denied: [Bug 75376] Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl : [Attachment 121068] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Raymond <rgbbones at gmail.com>'s
request for review:
Bug 75376: Remove unnecessary [Custom] attribute in
CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=75376

Attachment 121068: Patch
https://bugs.webkit.org/attachment.cgi?id=121068&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121068&action=review


> LayoutTests/canvas/philip/tests/2d.pattern.image.string.html:15
> -try { var _thrown = false; ctx.createPattern('../images/red.png',
'repeat');} catch (e) { if (e.code != DOMException.TYPE_MISMATCH_ERR)
_fail("Failed assertion: expected exception of type TYPE_MISMATCH_ERR, got:
"+e.message); _thrown = true; } finally { _assert(_thrown, "should throw
exception of type TYPE_MISMATCH_ERR: ctx.createPattern('../images/red.png',
'repeat')"); }
> +try { var _thrown = false; ctx.createPattern('../images/red.png',
'repeat');} catch (e) { if (!(e instanceof TypeError)) _fail("Failed assertion:
expected exception of type TypeError, got: "+e.message); _thrown = true; }
finally { _assert(_thrown, "should throw exception of type TypeError:
ctx.createPattern('../images/red.png', 'repeat')"); }

I don't think we're supposed to change these tests.  They're a test suite
written by philip.  We should just update the expected results.

> LayoutTests/canvas/philip/tests/2d.pattern.image.undefined.html:17
> -} catch (e) { if (e.code != DOMException.TYPE_MISMATCH_ERR) _fail("Failed
assertion: expected exception of type TYPE_MISMATCH_ERR, got: "+e.message);
_thrown = true; } finally { _assert(_thrown, "should throw exception of type
TYPE_MISMATCH_ERR: ctx.createPattern(undefined, 'repeat')"); }
> +} catch (e) { if (!(e instanceof TypeError)) _fail("Failed assertion:
expected exception of type TypeError, got: "+e.message); _thrown = true; }
finally { _assert(_thrown, "should throw exception of type TypeError:
ctx.createPattern(undefined, 'repeat')"); }

Ditto.