[webkit-reviews] review denied: [Bug 73180] CSS3 currentColor on outline-color gets treated as inherit : [Attachment 117983] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied  review:
Bug 73180: CSS3 currentColor on outline-color gets treated as inherit
https://bugs.webkit.org/show_bug.cgi?id=73180

Attachment 117983: Patch
https://bugs.webkit.org/attachment.cgi?id=117983&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
David Barr mentioned on IRC today that this test case is a "mirror of
[<http://trac.webkit.org/browser/trunk/LayoutTests/fast/css/background-currentc
olor.html>]." We shouldn't duplicate code. At the very least we should add a
description to this test case (as mentioned by Ryosuke in comment #12). One
step further, we should extract the common code between these test. Event
further, we should abstract runTest() such that it takes as an argument the CSS
property to test. Even better, we should make use of the functionality in
<http://trac.webkit.org/browser/trunk/LayoutTests/fast/js/resources/js-test-pre
.js> instead of rolling our own analogous testing support, such as the log()
function. We may also benefit from more descriptive PASS/FAIL message by using
the testing functionality in js-test-pre.js. We can do these tasks in separate
bugs.