[webkit-reviews] review granted: [Bug 75504] Web Inspector: Access to Node Highlighting info without drawing : [Attachment 121017] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 75504: Web Inspector: Access to Node Highlighting info without drawing
https://bugs.webkit.org/show_bug.cgi?id=75504

Attachment 121017: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=121017&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121017&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:361
> +void getOrDrawNodeHighlight(GraphicsContext* context, HighlightData*
highlightData, Highlight* highlight)

Should these be static?

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:463
> +void getOrDrawRectHighlight(GraphicsContext* context, Document* document,
HighlightData* highlightData, Highlight *highlight)

Ditto.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:512
> +	   getOrDrawNodeHighlight(NULL, highlightData, highlight);

Use 0 or nullptr instead of NULL.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:514
> +	   getOrDrawRectHighlight(NULL, document, highlightData, highlight);

Ditto.