[webkit-reviews] review granted: [Bug 74980] Leak of WebNotificationClient when page is destroyed : [Attachment 120999] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 74980: Leak of WebNotificationClient when page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=74980

Attachment 120999: Patch
https://bugs.webkit.org/attachment.cgi?id=120999&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120999&action=review


It may be worth adding comments to the ChangeLogs for the ports that are
getting empty implementations of the new client method briefly mentioning why
they're empty rather than doing what WebKit/mac and WebKit2 are doing
(different ownership model for the Client object presumably?).

> Source/WebCore/ChangeLog:3
> +	   [WK2] Leak of WebNotificationClient when page is destroyed

Seems like the [WK2] should be removed since it appears to also leak on WebKit1
for Mac.