[webkit-reviews] review granted: [Bug 56591] [chromium] Support RTL pages and elements in the compositor : [Attachment 120982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 3 14:00:43 PST 2012


James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 56591: [chromium] Support RTL pages and elements in the compositor
https://bugs.webkit.org/show_bug.cgi?id=56591

Attachment 120982: Patch
https://bugs.webkit.org/attachment.cgi?id=120982&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120982&action=review


Sweet! That's so easy.

> Source/WebKit/chromium/src/NonCompositedContentHost.cpp:138
> +void NonCompositedContentHost::paintContents(const WebCore::GraphicsLayer*
graphicsLayer, WebCore::GraphicsContext& context,
WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& clipRect)

nit: no need to name the graphicsLayer parameter here


More information about the webkit-reviews mailing list