[webkit-reviews] review canceled: [Bug 65838] Implement temporal dimension portion of Media Fragments URI specification for video/audio : [Attachment 120842] Updated patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has canceled Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 65838: Implement temporal dimension portion of Media Fragments URI
specification for video/audio
https://bugs.webkit.org/show_bug.cgi?id=65838

Attachment 120842: Updated patch
https://bugs.webkit.org/attachment.cgi?id=120842&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
(In reply to comment #11)
> (From update of attachment 120842 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=120842&action=review
> 
> I briefly looked at this patch and noticed some minor nits. I am not formally
reviewing this patch.
> 
> > Source/WebCore/html/MediaFragmentURIParser.cpp:14
> > + *     * Neither the name of Google Inc. nor the names of its
> 
> Is this license block correct?  Notice it references Google and it's a
three-clause BSD license. The preferred license block for new files is
<http://trac.webkit.org/browser/trunk/Source/WebKit/LICENSE>. That being said,
you would know best as to which license block Apple uses.
> 
Oops, fixed!

> > Source/WebCore/html/MediaFragmentURIParser.cpp:38
> > +#include "KURL.h"
> 
> It's unnecessary to include this file since it's included by file
MediaFragmentURIParser.h (above).
> 
Thanks, fixed.

> > Source/WebCore/html/MediaFragmentURIParser.h:14
> > + *     * Neither the name of Google Inc. nor the names of its
> 
> Is this license block correct?  Notice it references Google and it's a
three-clause BSD license. The preferred license block for new files is
<http://trac.webkit.org/browser/trunk/Source/WebKit/LICENSE>. That being said,
you would know best as to which license block Apple uses.
> 
Fixed.

> > Source/WebCore/html/MediaFragmentURIParser.h:36
> > +#include <KURL.h>
> 
> Shouldn't this be written using double quotes-notation instead of
angle-bracket notation?
>
Fixed.

Thanks for taking a look!