[webkit-reviews] review granted: [Bug 75443] getComputedStyle for list-style is not implemented. : [Attachment 120891] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 75443: getComputedStyle for list-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75443

Attachment 120891: Patch
https://bugs.webkit.org/attachment.cgi?id=120891&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120891&action=review


>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.htm
l:56
>
+shouldBe("computedStyle.getPropertyCSSValue('list-style').item(2).getStringVal
ue()", "'none'");

I would maybe add some tests that set listStyleType, listStylePosition, or
listStyleImage and make sure that list-style is properly updated.  Up to you.